Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Add atd_offset to posfilter config model #213

Merged
merged 4 commits into from
Jan 21, 2024

Conversation

madhavmk
Copy link
Collaborator

* Linked to Issue seafloor-geodesy#211
* Add AtdOffset pydantic model to handle antenna transducer offset config.
@madhavmk madhavmk requested a review from lsetiawan January 14, 2024 05:29
@madhavmk
Copy link
Collaborator Author

Hello @lsetiawan,
Before merging this PR, I need your help in adding valid sample test data to the tests/data/2022/NCL1/208/posfilter/RPH file.
Thanks!

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b77fd0) 49.78% compared to head (f7945d1) 49.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   49.78%   49.78%           
=======================================
  Files          16       16           
  Lines         932      932           
=======================================
  Hits          464      464           
  Misses        468      468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madhavmk
Copy link
Collaborator Author

Hello @lsetiawan, Before merging this PR, I need your help in adding valid sample test data to the tests/data/2022/NCL1/208/posfilter/RPH file. Thanks!

Update: This data was added in PR #212

Copy link
Member

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the commented stuff above, otherwise you are good to merge when ready 😄

@madhavmk madhavmk merged commit 60d6ff4 into seafloor-geodesy:main Jan 21, 2024
6 checks passed
@madhavmk madhavmk deleted the issue_211 branch May 14, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants