Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added azimuth and elevation calc #156

Merged
merged 3 commits into from
Sep 27, 2023
Merged

feat: Added azimuth and elevation calc #156

merged 3 commits into from
Sep 27, 2023

Conversation

lsetiawan
Copy link
Member

Added 'ecef2ae' function to compute azimuth and elevation. Additionally, 'azimuth' and 'elevation' properties are now added to the 'SolverTransponder' object on instantiation.

Added 'ecef2ae' function to compute azimuth and elevation.
Additionally, 'azimuth' and 'elevation' properties are now added
to the 'SolverTransponder' object on instantiation.
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (2f9a6f0) 40.08% compared to head (f384ec0) 38.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   40.08%   38.94%   -1.14%     
==========================================
  Files          15       15              
  Lines         711      742      +31     
==========================================
+ Hits          285      289       +4     
- Misses        426      453      +27     
Files Coverage Δ
src/gnatss/utilities/geo.py 34.14% <12.90%> (-65.86%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsetiawan
Copy link
Member Author

Part of the work for #149

Added 'calc_enu_comp' to the 'geo' module for computing the
mean 'e,n,u' components of residuals using the azimuth and elevation
of the transponders
Copy link
Contributor

@aniketfadia96 aniketfadia96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor formatting suggestion in the docstrings. LGTM overall.

@lsetiawan lsetiawan merged commit f0d68ef into seafloor-geodesy:main Sep 27, 2023
@lsetiawan lsetiawan deleted the offsets branch September 27, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants