Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loaders): Add loader function for RPH and flexible file gathering #147

Merged
merged 5 commits into from
Aug 25, 2023
Merged

feat(loaders): Add loader function for RPH and flexible file gathering #147

merged 5 commits into from
Aug 25, 2023

Conversation

lsetiawan
Copy link
Member

Overview

This PR introduces 2 things:

  • A new load_roll_pitch_heading method to load RPH file(s)
  • A new proc argument to gather_files method so that it can grab paths for the posfilter process

Closes #118

Added Roll Pitch Heading column constants
Added 'load_roll_pitch_heading' function to load
Roll Pitch Heading (RPH) data from a set of files
to a single pandas dataframe.
Added 'proc' argument to 'gather_files' function
so that user can choose to get file paths for
posfilter process
Modified the test_main.py and 'test_gather_files'
test to include testing for the new 'proc' argument
for flexible file gathering.
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 73.33% and project coverage change: +0.45% 🎉

Comparison is base (27375d4) 40.99% compared to head (2f3bafd) 41.44%.
Report is 1 commits behind head on main.

❗ Current head 2f3bafd differs from pull request most recent head d824227. Consider uploading reports for the commit d824227 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   40.99%   41.44%   +0.45%     
==========================================
  Files          15       15              
  Lines         666      678      +12     
==========================================
+ Hits          273      281       +8     
- Misses        393      397       +4     
Files Changed Coverage Δ
src/gnatss/loaders.py 22.58% <20.00%> (-0.23%) ⬇️
src/gnatss/constants/__init__.py 100.00% <100.00%> (ø)
src/gnatss/main.py 19.06% <100.00%> (+1.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aniketfadia96 aniketfadia96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/gnatss/loaders.py Outdated Show resolved Hide resolved
@lsetiawan lsetiawan merged commit ec129d4 into seafloor-geodesy:main Aug 25, 2023
@lsetiawan lsetiawan deleted the lsetiawan/issue118 branch August 25, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loader function for Roll Pitch Heading data (RPH_TWTT)
2 participants