-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copyright dates for generated Cargo manifests #85
base: main
Are you sure you want to change the base?
Update copyright dates for generated Cargo manifests #85
Conversation
Signed-off-by: Nick Spinale <[email protected]>
Copyright years should usually not be updated in bulk, at least not if the idea is to figure out the year of the most recent original copyright on the file. It doesn't renew automatically, only if there have been significant changes to the file. Lots of people do this, but they are wrong ;-) |
I'm aware of the general rules, but I thought this case might be different. All rust-sel4/hacking/cargo-manifest-management/manifest-scope.nix Lines 84 to 86 in 63ce236
For this PR, I changed the year in that snippet and then ran the typical What do you think about this particular case? The An alternative would be to include the year for the copyright line at the source-level in |
The copyright of generated code would be a mix of the copyright of the input to the generator and the generator itself, but the year/time it is generated does not really enter into it. So I guess the correct thing would be to take the year of the input file on this one. It's not really that big a deal, I confess I just saw the large number of files with the bulk update and reacted to that. If it is too much of a hassle, I'd actually just leave it. Generally you don't really gain anything from updating the copyright year anyway. I try to keep it current on the files with significant changes, but we probably should just really not bother, because by the time copyright runs out I hope we have shifted languages and maybe computing paradigms a few times :-) |
What about |
Those would be fine |
By this, do you mean that it would be fine to label those with the year 2023? |
2023 -> 2024