Update arch-split doc; rename arch_split->arch-split #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prefer arch_global_naming * prefer arch_requalify commands over interpretation * indicate consts might need to be requalified in Arch theories * explain (in Arch) + requalify pattern for generic consequences of arch-specific properties Signed-off-by: Rafal Kolanski <[email protected]>
Xaphiosis
added
docs
lsf37
reviewed
Jul 24, 2024
lsf37
approved these changes
Jul 24, 2024
corlewis
approved these changes
Jul 24, 2024
Comment on lines
+277
to
+282
| In some cases, consts/types/facts may be thrown into the `Arch` context without | ||
| further qualification. In such cases, normal requalification may be used: | ||
|
|
||
| ```isabelle | ||
| requalify_consts Arch.empty_context (* standard locale version, likely due to missing global_naming *) | ||
| ``` |
There was a problem hiding this comment.
Do we even want to mention this, if we're wanting to fix all cases of it?
There was a problem hiding this comment.
Possibly, because we do sometimes do lemma (in Arch) foo with an immediate requalify_facts Arch.foo, so it's worth knowing about at least. I think I explain that case in the docs now.
Unifying the tag between Github labels, docs, and so on will make it less confusing to grep for and deal with. Signed-off-by: Rafal Kolanski <[email protected]>
Xaphiosis
force-pushed
the
arch_split_doc
branch
from
cbb8d4e to
5d4090e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a noisy commit for the global rename, which isn't interesting beyond the commit message.
The main thing I'd like a review of is the updates to
docs/arch-split.md(separate commit) to see whether things make sense. The changes are based off of the test deployment work I did for AARCH64 AInvs.