Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prove awaken_ccorres #796

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Prove awaken_ccorres #796

merged 1 commit into from
Jul 25, 2024

Conversation

michaelmcinerney
Copy link
Contributor

No description provided.

@michaelmcinerney michaelmcinerney added the MCS related to `rt` branch and mixed-criticality systems label Jul 17, 2024
@michaelmcinerney michaelmcinerney self-assigned this Jul 17, 2024
@michaelmcinerney michaelmcinerney force-pushed the michaelm-awaken_ccorres branch 2 times, most recently from 6ceb081 to 198dfa6 Compare July 23, 2024 07:34
@Xaphiosis
Copy link
Member

I think the approach and proofs look ok. I'm as always a bit worried about the tendency to not have any comments in the proofs to help separate things or guide a potential reader/victim.

For when this isn't a draft: the commit tags aren't right btw (no rt, RISCV64 only, etc)

@michaelmcinerney michaelmcinerney force-pushed the michaelm-awaken_ccorres branch from 198dfa6 to 5036f43 Compare July 24, 2024 13:29
Signed-off-by: Michael McInerney <[email protected]>
@michaelmcinerney michaelmcinerney force-pushed the michaelm-awaken_ccorres branch from 5036f43 to 8912761 Compare July 24, 2024 13:30
@michaelmcinerney michaelmcinerney marked this pull request as ready for review July 25, 2024 01:25
@michaelmcinerney
Copy link
Contributor Author

Now (finally) ready for review.

I have added rt to the commit message, but I wasn't sure what to do about adding riscv. We agreed that we wouldn't add riscv to the crefine tag, since RISCV is the only arch we're doing for MCS at the moment. I have still been adding riscv to refine, since we at one point had both ARM and RISCV working for Refine, but we're now just back to RISCV, and I wasn't sure how to add riscv refine without then mentioning the other half a dozen sessions I'm changing here...

Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this one. You're right about the commit message, rt does seem to have different standards and in this case I have no idea how they would hang together usefully.

@michaelmcinerney michaelmcinerney merged commit 5554410 into rt Jul 25, 2024
10 of 11 checks passed
@michaelmcinerney michaelmcinerney deleted the michaelm-awaken_ccorres branch July 25, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MCS related to `rt` branch and mixed-criticality systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants