Additional Core/Peripheral Classification Methods #276
Conversation
Base implementation for new classification metrics. Documentation and testing still missing. Signed-off-by: Leo Sendelbach <[email protected]>
Tests use already existing network, this test cases are quite small. Additional research into potential rounding errors may be required. Signed-off-by: Leo Sendelbach <[email protected]>
Add default documentation, same as for already existing classification methods Signed-off-by: Leo Sendelbach <[email protected]>
add new entry under 'unversioned" Signed-off-by: Leo Sendelbach <[email protected]>
Leo-Send
changed the title
Also minor fixes as requested in PR Signed-off-by: Leo Sendelbach <[email protected]>
Changed ordering in readme Signed-off-by: Leo Sendelbach <[email protected]>
tests hierarchy with network previously used for another unit test Signed-off-by: Leo Sendelbach <[email protected]>
formulation change as requested Signed-off-by: Leo Sendelbach <[email protected]>
There was a problem hiding this comment.
As I haven't had a look at the tests yet, I have now done so. I only have a few minor comments (but I did not check the actual centrality values; especially for eccentricity, I still don't have an impression whether the values do make sense or not 🙈)
In addition to my comments below, please don't forget about the changes to the README regarding "author networks" that we have agreed on in today's meeting.
| @@ -18,6 +18,7 @@ | |||
| ## Copyright 2019 by Christian Hechtl <[email protected]> | |||
| ## Copyright 2021 by Christian Hechtl <[email protected]> | |||
| ## Copyright 2023-2024 by Maximilian Löffler <[email protected]> | |||
| ## Copyright 2024 by Leo Sendelbach <[email protected]> | |||
There was a problem hiding this comment.
Please update the copyright header and include 2025 😉
|
|
||
| ## Act | ||
| result = get.author.class.network.hierarchy(test.network) | ||
| ## Assert |
There was a problem hiding this comment.
Could you please add a blank line before the comment?
| row.names(result[["peripheral"]]) = NULL | ||
| expect_equal(expected, result) | ||
| }) | ||
|
|
||
| # TODO: Add a test for hierarchy classification |
There was a problem hiding this comment.
Please remove this TODO comment as soon as you have added another test for hierarchy classification. Thanks!
| @@ -22,6 +22,7 @@ | |||
| ## Copyright 2019 by Thomas Bock <[email protected]> | |||
| ## Copyright 2019 by Jakob Kronawitter <[email protected]> | |||
| ## Copyright 2021 by Johannes Hostert <[email protected]> | |||
| ## Copyright 2024 by Leo Sendelbach <[email protected]> | |||
There was a problem hiding this comment.
Please also update the copyright header here - some of your last changes have been added in 2025.
Prerequisites
showcase.Rwith respect to my changes.dev.Description
Add four new metric which can be used for the classification of authors into core and peripheral:
Betweenness, which measures the number of shortest paths between developers that go through a given developer vertex;
Closeness, which measures how close a developer is to all others by taking the inverse of the sum of all of it's shortest paths;
Pagerank, which is based on Google's Pagerank algorithm, which is closely related to Eigenvector Centrality;
Eccentricity, which measures the distance to the furthest developer vertex.
Changelog
Added