-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing labels to workloads in FeaturePerfCSCollection #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
varats/varats/projects/perf_tests/feature_perf_cs_collection.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonas Kaufmann <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #780 +/- ##
=========================================
Coverage 67.48% 67.48%
=========================================
Files 322 322
Lines 24437 24437
=========================================
Hits 16491 16491
Misses 7946 7946
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I'll relay this to the BB devs. For me a label would always make sense, if no label is provided we could just take the name of the command as a label. In the end, everything should have some form of printable name. |
Suggested in se-sic/VaRA-Tool-Suite#780 We just use the command's binary name by default, if no label is available.
#748 added new workloads without labels for FeaturePerfCSCollection. However,
create_workload_specific_filename
expects labelsVaRA-Tool-Suite/varats-core/varats/experiment/workload_util.py
Line 106 in 06c2d34
cmd.label
isNone
.It might be a good idea to add a check for missing labels when creating a workload. But for now just define some labels.