Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing labels to workloads in FeaturePerfCSCollection #780

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

danjujan
Copy link
Contributor

#748 added new workloads without labels for FeaturePerfCSCollection. However, create_workload_specific_filename expects labels

and fails if cmd.label is None.
It might be a good idea to add a check for missing labels when creating a workload. But for now just define some labels.

Copy link
Contributor

@jonas-kaufmann jonas-kaufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5fabb56) 67.48% compared to head (2b8cca7) 67.48%.

Additional details and impacted files
@@            Coverage Diff            @@
##           vara-dev     #780   +/-   ##
=========================================
  Coverage     67.48%   67.48%           
=========================================
  Files           322      322           
  Lines         24437    24437           
=========================================
  Hits          16491    16491           
  Misses         7946     7946           
Impacted Files Coverage Δ
.../projects/perf_tests/feature_perf_cs_collection.py 58.13% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vulder
Copy link
Contributor

vulder commented Apr 3, 2023

#748 added new workloads without labels for FeaturePerfCSCollection. However, create_workload_specific_filename expects labels

and fails if cmd.label is None.
It might be a good idea to add a check for missing labels when creating a workload. But for now just define some labels.

I'll relay this to the BB devs. For me a label would always make sense, if no label is provided we could just take the name of the command as a label. In the end, everything should have some form of printable name.

@simbuerg

simbuerg added a commit to PolyJIT/benchbuild that referenced this pull request Apr 4, 2023
Suggested in se-sic/VaRA-Tool-Suite#780

We just use the command's binary name by default, if no label is
available.
@vulder vulder merged commit 5e6af71 into vara-dev Apr 4, 2023
@vulder vulder deleted the fix-missing-labels branch April 4, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants