Fixes #610 using unique constraint on subsets of data when fitting a model #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katxiao
suggested changes
Oct 22, 2021
- sample less than the rows used for fitting - sample not only one row
katxiao
approved these changes
Oct 25, 2021
- moves sampling to Run section from Assert - assert that Unique column is really unique - add link to Github Issue in test
csala
reviewed
Oct 29, 2021
|
|
||
| # Assert | ||
| assert len(model.sample(2)) == 2 | ||
| assert len(samples) == 2 | ||
| assert samples["error_column"].is_unique |
There was a problem hiding this comment.
Oh, this is cool! I did not know about this is_unique attribute!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #610 and allows fitting a model to a subset of data when also specifying the use of a
Uniqueconstraint.The indexes are reset before each fitting process by using
.reset_index(drop=True)for all data passed to thefitmethod.