-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: PARSynthesizer
not being able to conditionally sample with date time as context
#2347
Fix: PARSynthesizer
not being able to conditionally sample with date time as context
#2347
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2347 +/- ##
==========================================
+ Coverage 98.57% 98.59% +0.02%
==========================================
Files 59 59
Lines 6101 6120 +19
==========================================
+ Hits 6014 6034 +20
+ Misses 87 86 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
36e6394
to
f640e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to make it seem less random that datetime is getting special treatment, we can make some generalized functions that exist to handle these extra transformations and changes to metadata
6274474
to
40c243a
Compare
Resolves #2187
CU-86b1pxjbd