Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PARSynthesizer not being able to conditionally sample with date time as context #2347

Conversation

pvk-developer
Copy link
Member

Resolves #2187
CU-86b1pxjbd

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (0ddaf6a) to head (40c243a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2347      +/-   ##
==========================================
+ Coverage   98.57%   98.59%   +0.02%     
==========================================
  Files          59       59              
  Lines        6101     6120      +19     
==========================================
+ Hits         6014     6034      +20     
+ Misses         87       86       -1     
Flag Coverage Δ
integration 82.25% <100.00%> (+0.07%) ⬆️
unit 97.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvk-developer pvk-developer force-pushed the issue-2187-conditional-sampling-error-when-using-datetime-column-in-par-synthesizer branch from 36e6394 to f640e58 Compare January 16, 2025 17:52
@pvk-developer pvk-developer requested a review from a team as a code owner January 16, 2025 17:52
sdv/sequential/par.py Outdated Show resolved Hide resolved
sdv/sequential/par.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to make it seem less random that datetime is getting special treatment, we can make some generalized functions that exist to handle these extra transformations and changes to metadata

sdv/sequential/par.py Outdated Show resolved Hide resolved
sdv/sequential/par.py Outdated Show resolved Hide resolved
@pvk-developer pvk-developer force-pushed the issue-2187-conditional-sampling-error-when-using-datetime-column-in-par-synthesizer branch from 6274474 to 40c243a Compare January 22, 2025 18:07
@pvk-developer pvk-developer merged commit ca7892c into main Jan 22, 2025
41 checks passed
@pvk-developer pvk-developer deleted the issue-2187-conditional-sampling-error-when-using-datetime-column-in-par-synthesizer branch January 22, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional sampling error when using a datetime column as a context column with PAR Synthesizer
4 participants