Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a proper ValueError message when the Metadata is empty #2255

Conversation

pvk-developer
Copy link
Member

Resolves #2252
CU-86b2d6au4

@sdv-team
Copy link
Contributor

sdv-team commented Oct 7, 2024

@pvk-developer pvk-developer marked this pull request as ready for review October 7, 2024 15:04
@pvk-developer pvk-developer requested a review from a team as a code owner October 7, 2024 15:04
@pvk-developer pvk-developer requested review from rwedge and removed request for a team October 7, 2024 15:04
@pvk-developer pvk-developer requested review from R-Palazzo and removed request for rwedge October 8, 2024 09:40
@pvk-developer pvk-developer force-pushed the issue-2252-valueerror-raised-when-adding-columns-to-new-metadata branch from b64ae2f to 361fefc Compare October 8, 2024 09:41
@pvk-developer pvk-developer force-pushed the issue-2252-valueerror-raised-when-adding-columns-to-new-metadata branch from 361fefc to 0b2ab94 Compare October 8, 2024 14:30
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvk-developer pvk-developer merged commit 6ae4840 into main Oct 8, 2024
39 checks passed
@pvk-developer pvk-developer deleted the issue-2252-valueerror-raised-when-adding-columns-to-new-metadata branch October 8, 2024 15:02
@pvk-developer pvk-developer added this to the 1.17.1 milestone Oct 8, 2024
@amontanez24 amontanez24 removed this from the 1.17.1 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError raised when adding columns to a new Metadata instance
5 participants