Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for num_rows column in _sample_children method of HMA #2090

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Remove check for num_rows column in _sample_children method of HMA #2090

merged 1 commit into from
Jun 26, 2024

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 25, 2024

@gsheni gsheni self-assigned this Jun 25, 2024
@sdv-team
Copy link
Contributor

Task linked: CU-86ayu4c14 SDV - Investigate HMA case where parent is missing num_rows column #1703

@gsheni gsheni requested review from amontanez24 and frances-h June 25, 2024 20:18
@gsheni gsheni marked this pull request as ready for review June 25, 2024 20:18
@gsheni gsheni requested a review from a team as a code owner June 25, 2024 20:18
@gsheni gsheni changed the title Remove check for num_rows column in HMA Remove check for num_rows column in _sample_children method of HMA Jun 25, 2024
amontanez24
amontanez24 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gsheni gsheni merged commit 0173c77 into main Jun 26, 2024
76 checks passed
@gsheni gsheni deleted the issue-1703-remove-num-rows-check branch June 26, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frances-h frances-h frances-h approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate HMA case where parent is missing num_rows column
4 participants
@gsheni @sdv-team @amontanez24 @frances-h