Fix drop_unknown_references for null foreign keys #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
approved these changes
Feb 27, 2024
sdv/_utils.py
Outdated
| @@ -271,3 +273,25 @@ def _get_rows_to_drop(metadata, data): | |||
| relationships = [rel for rel in relationships if rel not in relationships_parent] | |||
|
|
|||
| return table_to_idx_to_drop | |||
|
|
|||
|
|
|||
| def _validate_foreign_keys(metadata, data): | |||
There was a problem hiding this comment.
so that this doesn't get confused with the _validate_foreign_keys method in the metadata can we call this _validate_foreign_keys_not_null or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86azg9kz9
Resolve #1820