Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional sampling with constraints #1783

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

fealho
Copy link
Member

@fealho fealho commented Feb 7, 2024

CU-86az149kj, Resolve #1737.

@sdv-team
Copy link
Contributor

sdv-team commented Feb 7, 2024

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74baae9) 97.13% compared to head (e7452d5) 97.11%.

❗ Current head e7452d5 differs from pull request most recent head d9b3a6d. Consider uploading reports for the commit d9b3a6d to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
- Coverage   97.13%   97.11%   -0.03%     
==========================================
  Files          49       49              
  Lines        4614     4616       +2     
==========================================
+ Hits         4482     4483       +1     
- Misses        132      133       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review February 7, 2024 21:12
@fealho fealho requested a review from a team as a code owner February 7, 2024 21:12
@fealho fealho requested review from lajohn4747 and frances-h and removed request for a team February 7, 2024 21:12
@fealho fealho merged commit e85f3e1 into main Feb 12, 2024
37 checks passed
@fealho fealho deleted the issue-1737-scalar-range branch February 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to conditionally sample some rows when using a ScalarRange constraint
5 participants