Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization isn't useful when there are too many data points. Can we subsample? #1672

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Visualization isn't useful when there are too many data points. Can we subsample? #1672

merged 7 commits into from
Nov 13, 2023

Conversation

R-Palazzo
Copy link
Contributor

CU-85zt7vbp9
Resolve #1461

@R-Palazzo R-Palazzo requested a review from a team as a code owner November 8, 2023 16:36
@amontanez24
Copy link
Contributor

Task linked: CU-85zt7vbp9 SDV - Visualization isn't useful when there are too many data points. Can we subsample? #1461

@R-Palazzo R-Palazzo removed the request for review from a team November 8, 2023 16:36
@R-Palazzo R-Palazzo changed the title Issue 1461 visualization too many points Visualization isn't useful when there are too many data points. Can we subsample? Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96aaa69) 96.87% compared to head (588f155) 96.87%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1672   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          47       47           
  Lines        4347     4351    +4     
=======================================
+ Hits         4211     4215    +4     
  Misses        136      136
Files Coverage Δ
sdv/evaluation/multi_table.py 100.00% <ø> (ø)
sdv/evaluation/single_table.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amontanez24
amontanez24 reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add an integration test?

amontanez24
amontanez24 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@R-Palazzo R-Palazzo merged commit 0f4fa36 into main Nov 13, 2023
@R-Palazzo R-Palazzo deleted the issue-1461-visualization-too-many-points branch November 13, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@fealho fealho fealho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualization isn't useful when there are too many data points. Can we subsample?
4 participants
@R-Palazzo @amontanez24 @codecov-commenter @fealho