Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata improvements #1610

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Metadata improvements #1610

merged 7 commits into from
Sep 27, 2023

Conversation

amontanez24
Copy link
Contributor

@amontanez24 amontanez24 commented Sep 27, 2023

resolves #1515,
resolves #1516,
resolves #1521,
resolves #1522,
resolves #1584,
resolves #1598

R-Palazzo and others added 7 commits September 26, 2023 19:56
* def unit test determine methods

* add unit test detect_column

* cleaning

* add integration tests

* import

* remove 'u' kind

* update condition and test

* address comments

* address comments

* rebase

* warning datetime detection

* silence pandas warning

* subsample datetime detection

* address comments

* rebase
* def support unknown

* add test

* not pii 2
* Automatically detect primary keys

* update docstring and add clarification comment
* Automatically detect relationships and add ability to remove relationships

* Add and fix tests

* lint

* handle orphans better and update tests
@amontanez24 amontanez24 requested a review from a team as a code owner September 27, 2023 00:58
@amontanez24 amontanez24 requested review from rwedge and removed request for a team September 27, 2023 00:58
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0bc7508) 97.04% compared to head (7df4c5b) 97.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1610      +/-   ##
==========================================
+ Coverage   97.04%   97.15%   +0.11%     
==========================================
  Files          48       48              
  Lines        4091     4180      +89     
==========================================
+ Hits         3970     4061      +91     
+ Misses        121      119       -2     
Files Coverage Δ
sdv/data_processing/data_processor.py 97.60% <100.00%> (+0.55%) ⬆️
sdv/metadata/multi_table.py 99.54% <100.00%> (+0.03%) ⬆️
sdv/metadata/single_table.py 99.26% <100.00%> (+0.10%) ⬆️
sdv/utils.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontanez24 amontanez24 merged commit ea98c89 into main Sep 27, 2023
@amontanez24 amontanez24 deleted the metadata-improvment branch September 27, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants