-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 134 add metadata validation #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csala
suggested changes
Jan 16, 2020
csala
reviewed
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 91.11% 90.81% -0.31%
==========================================
Files 12 12
Lines 788 838 +50
==========================================
+ Hits 718 761 +43
- Misses 70 77 +7
Continue to review full report at Codecov.
|
csala
approved these changes
Jan 21, 2020
JonathanDZiegler
pushed a commit
to JonathanDZiegler/SDV
that referenced
this pull request
Feb 7, 2022
* Fix default value * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #134
Added
validation
method and moved_validate_dataset_structure
from sdv.py to metadata.py.