Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 134 add metadata validation #145

Merged
merged 6 commits into from
Jan 21, 2020
Merged

Conversation

JDTheRipperPC
Copy link
Contributor

Resolves #134

Added validation method and moved _validate_dataset_structure from sdv.py to metadata.py.

@JDTheRipperPC JDTheRipperPC requested a review from csala January 16, 2020 08:41
sdv/metadata.py Outdated Show resolved Hide resolved
sdv/metadata.py Outdated Show resolved Hide resolved
sdv/metadata.py Outdated Show resolved Hide resolved
sdv/metadata.py Outdated Show resolved Hide resolved
sdv/metadata.py Outdated Show resolved Hide resolved
sdv/metadata.py Outdated Show resolved Hide resolved
sdv/metadata.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #145 into master will decrease coverage by 0.3%.
The diff coverage is 74.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   91.11%   90.81%   -0.31%     
==========================================
  Files          12       12              
  Lines         788      838      +50     
==========================================
+ Hits          718      761      +43     
- Misses         70       77       +7
Impacted Files Coverage Δ
sdv/sdv.py 97.43% <100%> (-0.24%) ⬇️
sdv/metadata.py 89.27% <74%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4793547...07ce3eb. Read the comment docs.

@csala csala merged commit a0f41c4 into master Jan 21, 2020
@csala csala deleted the issue_134_add_metadata_validation branch January 21, 2020 14:55
JonathanDZiegler pushed a commit to JonathanDZiegler/SDV that referenced this pull request Feb 7, 2022
* Fix default value

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Metadata Validation
3 participants