Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HMASynthesizer not able to fit when only primary keys and foreign keys are within a table. #1266

Conversation

pvk-developer
Copy link
Member

Resolves #1257

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 96.03% // Head: 95.86% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (29253a7) compared to base (2c98ef9).
Patch coverage: 72.22% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##           V1.0.0.dev    #1266      +/-   ##
==============================================
- Coverage       96.03%   95.86%   -0.18%     
==============================================
  Files              47       47              
  Lines            3660     3676      +16     
==============================================
+ Hits             3515     3524       +9     
- Misses            145      152       +7     
Impacted Files Coverage Δ
sdv/multi_table/base.py 98.93% <50.00%> (-0.53%) ⬇️
sdv/multi_table/hma.py 80.97% <65.38%> (-1.82%) ⬇️
sdv/data_processing/data_processor.py 97.06% <100.00%> (ø)
sdv/single_table/copulas.py 95.91% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pvk-developer pvk-developer marked this pull request as ready for review February 16, 2023 02:36
@pvk-developer pvk-developer requested a review from a team as a code owner February 16, 2023 02:36
@pvk-developer pvk-developer requested review from amontanez24 and removed request for a team February 16, 2023 02:36
sdv/multi_table/hma.py Show resolved Hide resolved
sdv/multi_table/base.py Outdated Show resolved Hide resolved
@pvk-developer pvk-developer force-pushed the issue-1257-hmasynthesizer-cannot-fit-primary-and-foreignkeys-only branch from a3887eb to 1f01f0d Compare February 16, 2023 18:37
@pvk-developer pvk-developer requested a review from fealho February 16, 2023 22:36
sdv/multi_table/hma.py Outdated Show resolved Hide resolved
@pvk-developer pvk-developer force-pushed the issue-1257-hmasynthesizer-cannot-fit-primary-and-foreignkeys-only branch from f655c19 to b8348e3 Compare February 17, 2023 13:52
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's just missing some testing (it's -0.18% in coverage).

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now!

@pvk-developer pvk-developer merged commit 82fcf3a into V1.0.0.dev Feb 17, 2023
@pvk-developer pvk-developer deleted the issue-1257-hmasynthesizer-cannot-fit-primary-and-foreignkeys-only branch February 17, 2023 18:11
amontanez24 pushed a commit that referenced this pull request Feb 17, 2023
…gn keys are within a table. (#1266)

* Add missing methods and fix hma.

* Fix randomness in probability density

* Use pcg

* Add integration tests and fix .values in finding parents

* Fix lint

* Remove generator and use state sequence

* Address comments

* Add unit test

* Add new test
amontanez24 pushed a commit that referenced this pull request Mar 23, 2023
…gn keys are within a table. (#1266)

* Add missing methods and fix hma.

* Fix randomness in probability density

* Use pcg

* Add integration tests and fix .values in finding parents

* Fix lint

* Remove generator and use state sequence

* Address comments

* Add unit test

* Add new test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants