-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HMASynthesizer
not able to fit when only primary keys and foreign keys are within a table.
#1266
Fix HMASynthesizer
not able to fit when only primary keys and foreign keys are within a table.
#1266
Conversation
Codecov ReportBase: 96.03% // Head: 95.86% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## V1.0.0.dev #1266 +/- ##
==============================================
- Coverage 96.03% 95.86% -0.18%
==============================================
Files 47 47
Lines 3660 3676 +16
==============================================
+ Hits 3515 3524 +9
- Misses 145 152 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a3887eb
to
1f01f0d
Compare
f655c19
to
b8348e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it's just missing some testing (it's -0.18% in coverage).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now!
…gn keys are within a table. (#1266) * Add missing methods and fix hma. * Fix randomness in probability density * Use pcg * Add integration tests and fix .values in finding parents * Fix lint * Remove generator and use state sequence * Address comments * Add unit test * Add new test
…gn keys are within a table. (#1266) * Add missing methods and fix hma. * Fix randomness in probability density * Use pcg * Add integration tests and fix .values in finding parents * Fix lint * Remove generator and use state sequence * Address comments * Add unit test * Add new test
Resolves #1257