Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pvk-developer committed Nov 9, 2022
1 parent 172a25f commit bd0f932
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions sdv/multi_table/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,13 @@ def _validate_foreign_keys(self, data):
if any(missing_values):
message = ', '.join(missing_values[:5].astype(str))
if len(missing_values) > 5:
message = f'({message}, + more).'
message = f'({message}, + more)'
else:
message = f'({message}).'
message = f'({message})'

errors.append(
f"Error: foreign key column '{relation['child_foreign_key']}' contains "
f'unknown references: {message} All the values in this column must '
f'unknown references: {message}. All the values in this column must '
'reference a primary key.'
)
if errors:
Expand Down Expand Up @@ -142,17 +142,16 @@ def validate(self, data):
try:
self._table_synthesizers[table_name].validate(table_data)

except (InvalidDataError, ValueError) as error:
if isinstance(error, InvalidDataError):
error_msg = f"Table: '{table_name}'"
for _error in error.errors:
error_msg += f'\nError: {_error}'

else:
error_msg = str(error)
except InvalidDataError as error:
error_msg = f"Table: '{table_name}'"
for _error in error.errors:
error_msg += f'\nError: {_error}'

errors.append(error_msg)

except ValueError as error:
errors.append(str(error))

except KeyError:
continue

Expand Down

0 comments on commit bd0f932

Please sign in to comment.