Add support for numpy 2.0.0 #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
approved these changes
Jun 25, 2024
amontanez24
reviewed
Jun 26, 2024
| @@ -17,7 +18,7 @@ def test_end_to_end(self): | |||
| result = column_pair_trends.get_score(real_data, synthetic_data, metadata) | |||
|
|
|||
| # Assert | |||
| assert result == 0.45654629583521095 | |||
| assert np.isclose(result, 0.45654629583521095, atol=1e-8) | |||
There was a problem hiding this comment.
what causes the inconsistency in values now?
There was a problem hiding this comment.
Seems with scipy 1.14, there is another decimal of accuracy added
R-Palazzo
force-pushed
the
issue-593-numpy2.0
branch
from
2db9c75
to
e30800b
Compare
amontanez24
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b0y0zqa
Resolve #593