Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print scores after every progress bar #540

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Mar 7, 2024

resolve #538

Print scores according to new spec.

Screenshot 2024-03-25 at 11 05 17 AM

@lajohn4747 lajohn4747 requested a review from a team as a code owner March 7, 2024 22:57
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (1844a99) to head (9f1b520).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   78.54%   78.52%   -0.02%     
==========================================
  Files         102      102              
  Lines        3728     3726       -2     
==========================================
- Hits         2928     2926       -2     
  Misses        800      800              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just awaiting confirmation that the slight change in spec is ok from @npatki ie. printing Column Pair Trends Score: instead of Score:

@npatki
Copy link
Contributor

npatki commented Mar 20, 2024

Just awaiting confirmation that the slight change in spec is ok from @npatki ie. printing Column Pair Trends Score: instead of Score:

FYI as discussed last week, this is fine by me @amontanez24

Copy link
Contributor

@npatki npatki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few differences from the original spec written in the issue

  1. Blocking We do not want to show the progress % in the TQDM bar because this is easily confused with the overall score
  2. (Not following spec but I'm OK with it) Spec had just the word Score rather than <Property Name> Score

Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lajohn4747 lajohn4747 merged commit 5fe4551 into main Mar 26, 2024
45 checks passed
@lajohn4747 lajohn4747 deleted the issue_538_fix_score_readability branch March 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve readability of the report scores when verbosity is on
5 participants