-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print scores after every progress bar #540
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
- Coverage 78.54% 78.52% -0.02%
==========================================
Files 102 102
Lines 3728 3726 -2
==========================================
- Hits 2928 2926 -2
Misses 800 800 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just awaiting confirmation that the slight change in spec is ok from @npatki ie. printing Column Pair Trends Score:
instead of Score:
FYI as discussed last week, this is fine by me @amontanez24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few differences from the original spec written in the issue
- Blocking We do not want to show the progress % in the TQDM bar because this is easily confused with the overall score
- (Not following spec but I'm OK with it) Spec had just the word
Score
rather than<Property Name> Score
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
resolve #538
Print scores according to new spec.