Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fit on training data for MLEfficacy #492

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fit on training data for MLEfficacy #492

merged 1 commit into from
Nov 1, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Nov 1, 2023

Resolve #291.

@fealho fealho marked this pull request as ready for review November 1, 2023 20:41
@fealho fealho requested a review from a team as a code owner November 1, 2023 20:41
@fealho fealho requested review from pvk-developer, rwedge and a team and removed request for a team and pvk-developer November 1, 2023 20:41
rwedge
rwedge approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho merged commit c6724ef into main Nov 1, 2023
90 checks passed
@fealho fealho deleted the issue-291-change-order-test-train branch November 1, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transformer should not be fit on test data
2 participants
@fealho @rwedge