Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SequenceLengthSimilarity docstrings #660

Closed
fealho opened this issue Nov 14, 2024 · 0 comments · Fixed by #662
Closed

Fix SequenceLengthSimilarity docstrings #660

fealho opened this issue Nov 14, 2024 · 0 comments · Fixed by #662
Assignees
@fealho
Labels
bug Something isn't working
Milestone
0.17.0

Comments

@fealho
Copy link
Member

fealho commented Nov 14, 2024 •
edited
Loading

Error Description

The docstrings for SequenceLengthSimilarity include the following:

SDMetrics/sdmetrics/timeseries/sequence_length_similarity.py

Lines 43 to 47 in 6bec051

Args:
real_data (Union[numpy.ndarray, pandas.DataFrame]):
The values from the real dataset.
synthetic_data (Union[numpy.ndarray, pandas.DataFrame]):
The values from the synthetic dataset.

The type hints for the real and synthetic data parameters are incorrect. They should be pd.Series, not Union[numpy.ndarray, pandas.DataFrame].
@fealho fealho added bug Something isn't working new Label applied to new issues and removed new Label applied to new issues labels Nov 14, 2024
@fealho fealho self-assigned this Nov 14, 2024
@fealho fealho added this to the 0.16.1 milestone Nov 14, 2024
@fealho fealho mentioned this issue Nov 14, 2024
Merged
@amontanez24 amontanez24 mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
bug Something isn't working
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Add InterRowMSAS, StatisticMSAS and SequenceLengthSimilarity metrics sdv-dev/SDMetrics
1 participant
@fealho