Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new get_cardinality_plot #445

Closed
amontanez24 opened this issue Sep 11, 2023 · 0 comments · Fixed by #453
Closed

Add new get_cardinality_plot #445

amontanez24 opened this issue Sep 11, 2023 · 0 comments · Fixed by #453
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Sep 11, 2023

Problem Description

As a user, sometimes the plot type selected by get_cardinality_plot is not the best. I'd like to be able to select the plot type to better visualize my data.

Expected behavior

  • In the sdmetrics.visualization module, add a method called get_cardinality_plot.
    • If the module/file doesn't exist, create it.
  • Use the current get_cardinality_plot function as a starting point.
    • Remove the metadata parameter
    • Add a new parameter called plot_type
      • plot_type can be 'distplot' or 'bar'
      • By default, use 'bar'
  • Delete the old get_cardinality_plot code

Additional context

  • Verify that a valid plot_type is given.
  • We no longer need any of the metadata validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants