Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new get_cardinality_plot #453

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

frances-h
Copy link
Contributor

@frances-h frances-h commented Sep 18, 2023

Resolve #445 and #447

@frances-h frances-h force-pushed the issue-445-new-get_cardinality_plot branch from 22c19bd to b1b7504 Compare September 18, 2023 16:29
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.06% 🎉

Comparison is base (3667b37) 76.47% compared to head (b1b7504) 76.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   76.47%   76.54%   +0.06%     
==========================================
  Files          91       92       +1     
  Lines        3324     3359      +35     
==========================================
+ Hits         2542     2571      +29     
- Misses        782      788       +6     
Files Changed Coverage Δ
sdmetrics/reports/utils.py 93.86% <ø> (-0.79%) ⬇️
sdmetrics/visualization.py 90.90% <90.90%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frances-h frances-h marked this pull request as ready for review September 18, 2023 16:53
@frances-h frances-h requested a review from a team as a code owner September 18, 2023 16:53
@frances-h frances-h requested review from pvk-developer and R-Palazzo and removed request for a team September 18, 2023 16:53
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ;)

@frances-h frances-h merged commit efeb278 into main Sep 20, 2023
45 checks passed
@frances-h frances-h deleted the issue-445-new-get_cardinality_plot branch September 20, 2023 14:39
@npatki npatki linked an issue Oct 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when using get_cardinality_plot on some schemas Add new get_cardinality_plot
4 participants