Validate set_config
#494
Merged
Validate set_config
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
requested changes
Apr 15, 2022
rdt/hyper_transformer.py
Outdated
|
|
||
| sdtypes = config['sdtypes'] | ||
| transformers = config['transformers'] | ||
| if sdtypes.keys() != transformers.keys(): |
There was a problem hiding this comment.
I don't know if they need to be in the same order. Can we just check that they contain the same elements?
Codecov Report
@@ Coverage Diff @@
## v1.0.0.dev #494 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 14 14
Lines 1239 1253 +14
============================================
+ Hits 1239 1253 +14
Continue to review full report at Codecov.
|
pvk-developer
approved these changes
Apr 19, 2022
amontanez24
approved these changes
Apr 19, 2022
tests/unit/test_hyper_transformer.py
Outdated
| The method should crash if ``sdytpes`` and ``transformers`` have different of columns. | ||
|
|
||
| Input: | ||
| - A config with only ``transformers``. |
There was a problem hiding this comment.
This isn't true for this case right?
pvk-developer
requested changes
Apr 20, 2022
fealho
force-pushed
the
issue-478-set-config
branch
from
38bd588 to
209466c
Compare
amontanez24
approved these changes
Apr 20, 2022
fealho
force-pushed
the
issue-478-set-config
branch
from
d91c28c to
c9ce1d0
Compare
pvk-developer
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #478.