Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hyper Transformer API #313

Merged
merged 7 commits into from
Oct 26, 2021
Merged

Update Hyper Transformer API #313

merged 7 commits into from
Oct 26, 2021

Conversation

amontanez24
Copy link
Contributor

resolves #298

@amontanez24 amontanez24 requested a review from a team as a code owner October 22, 2021 01:40
@amontanez24 amontanez24 requested review from fealho and removed request for a team October 22, 2021 01:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #313 (caefa91) into v0.6.0-dev (e3591fa) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.6.0-dev     #313      +/-   ##
==============================================
+ Coverage       87.94%   88.21%   +0.26%     
==============================================
  Files              11       12       +1     
  Lines             838      857      +19     
==============================================
+ Hits              737      756      +19     
  Misses            101      101
Impacted Files Coverage Δ
rdt/errors.py 100.00% <100.00%> (ø)
rdt/hyper_transformer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3591fa...caefa91. Read the comment docs.

@csala csala self-requested a review October 25, 2021 14:58
csala
csala approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amontanez24 amontanez24 force-pushed the issue-298-update-hyper-transformer-api branch from 351fe9e to caefa91 Compare October 25, 2021 23:16
csala
csala approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after the latest changes

@amontanez24 amontanez24 merged commit 599749d into v0.6.0-dev Oct 26, 2021
@amontanez24 amontanez24 deleted the issue-298-update-hyper-transformer-api branch October 26, 2021 15:22
amontanez24 added a commit that referenced this pull request Oct 26, 2021
@amontanez24
Update Hyper Transformer API (#313)
5d6b39e 
* HyperTransformer API name changes

* adding new methods

* changing set to update

* raising error when fitting is needed and renaming helper

* updating tests for error

* updating dev guide

* adding set_first_transformers_for_fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csala csala csala approved these changes

@fealho fealho fealho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amontanez24 @codecov-commenter @csala @fealho