Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff for linting, remove flake8, remove isort, remove pylint #93

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Mar 22, 2024

  • Added ruff for running linting
  • Added ruff commands to Makefile
  • Removed flake8 as dev dependency, since ruff does this, but faster
  • Remove isort as dev dependency, since ruff has the same function, but faster
  • Removed pylint as dev dependency, since ruff has more implemented rules
  • Removed setup.cfg

@gsheni gsheni self-assigned this Mar 22, 2024
@gsheni gsheni requested a review from a team as a code owner March 22, 2024 15:39
@gsheni gsheni requested review from amontanez24 and removed request for a team March 22, 2024 15:39
@gsheni gsheni changed the title Add ruff for linting, remove flake8, remove isort Add ruff for linting, remove flake8, remove isort, remove pylint Mar 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 84.49198% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 79.39%. Comparing base (ed3645b) to head (88127ad).

Files Patch % Lines
deepecho/models/base.py 11.76% 15 Missing ⚠️
deepecho/sequences.py 22.22% 7 Missing ⚠️
deepecho/models/basic_gan.py 92.00% 4 Missing ⚠️
deepecho/models/par.py 98.07% 2 Missing ⚠️
deepecho/demo.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   79.12%   79.39%   +0.27%     
==========================================
  Files           7        7              
  Lines         728      728              
==========================================
+ Hits          576      578       +2     
+ Misses        152      150       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deepecho/__init__.py Outdated Show resolved Hide resolved
@gsheni gsheni requested a review from amontanez24 March 25, 2024 18:48
@gsheni gsheni merged commit 3380134 into main Mar 25, 2024
45 checks passed
@gsheni gsheni deleted the add_ruff branch March 25, 2024 19:20
@gsheni gsheni restored the add_ruff branch March 25, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants