Log mech commands to a separate log file

yao/actor.py

@@ -14,12 +14,11 @@
 import pathlib
 import warnings
 
-from clu import Command
-from clu.legacy import LegacyActor
-
 from archon import log as archon_log
 from archon.actor.actor import ArchonBaseActor
 from archon.actor.tools import get_schema
+from clu import Command
+from clu.legacy import LegacyActor
 
 from yao import __version__, config
 from yao.alerts import AlertsBot
@@ -57,9 +56,14 @@ def __init__(self, *args, **kwargs):
 
         # TODO: this assumes one single mech controller, not one per spectrograph,
         # but in practice for now that's fine.
+
+        log_path = self.log.log_filename
+        mech_log = pathlib.Path(log_path).parent / "spec-mech.log" if log_path else None
+
         self.spec_mech = MechController(
             self.config["specMech"]["address"],
             self.config["specMech"]["port"],
+            log_path=str(mech_log),
         )
 
         # Add actor log handlers to the archon library to also get that logging.

yao/mech_controller.py

@@ -229,17 +229,28 @@ class MechController:
         The port of the host of the mech server.
     log
         A logger to which to write.
+    log_path
+        If ``log=None`` and ``log_path`` is provided, the log is saved to this
+        location using a rotating file handler.
 
     """
 
-    def __init__(self, address: str, port: int = 23, log: SDSSLogger | None = None):
+    def __init__(
+        self,
+        address: str,
+        port: int = 23,
+        log: SDSSLogger | None = None,
+        log_path: str | None = None,
+    ):
         self.reader: asyncio.StreamReader | None = None
         self.writer: asyncio.StreamWriter | None = None
 
         self.reboot: bool = False
         self.command_number: int = 0
 
-        self.log = log or SDSSLogger("boss-spech-mech-client")
+        self.log = log or SDSSLogger("yao.boss-spech-mech-client")
+        if log is None and log_path:
+            self.log.start_file_logger(log_path)
 
         self.spechMechAddress = address
         self.specMechPort = port