New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Redis' logger option #211

Merged

sds merged 1 commit into sds:master from jdelStrother:logging2

May 13, 2021

Contributor

jdelStrother commented May 12, 2021 •

edited

Loading

This allows passing a :logger option to MockRedis.new. The logging method is mostly ripped from redis' implementation here: https://github.com/redis/redis-rb/blob/6542934f01b9c390ee450bd372209a04bc3a239b/lib/redis/client.rb#L329-L351. As a result it also logs call_time - I'm not sure that's especially useful for MockRedis, but have left it in for the sake of mimicking the Redis implementation.

See also #198


          Add support for Redis' logger option

12aee2d

sds added the enhancement label

sds merged commit 0dc409c into sds:master

Owner

sds commented May 13, 2021

Thank you.

sds mentioned this pull request

Missing logger accessor attributes #198

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels