New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly set milliseconds ttl for set with px #180

Merged

sds merged 1 commit into sds:master from JeanMertz:set-px-fix

Apr 6, 2020

Contributor

JeanMertz commented Mar 29, 2020

Because expire calls to_i on the provided value, any millisecond precision is lost when a floating-point value is passed in.

The px duration in set is already supplied as an integer representing milliseconds, so we can pass it straight to pexpire.

The test didn't catch this mistake because it was using exact seconds in its test.


          fix: correctly set milliseconds ttl for set with px

a2d3a11

sds added the bug label

sds merged commit e7cef50 into sds:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug