-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Paths #22
Global Paths #22
Conversation
…f the issues with the feature grouping/stop points a lot more, as well as the hangs on the navigation/control panels)
… name grouping issue
… name grouping issue
…tures being removed from navigation info
…issues, particulary with targets not on screen at the time of search, which were falling back to a different, very bad elevation calculation
… wrapping on longitude.
…y fixed the zoom issue and seem to have a solution on flight/start mismatch by doing a pre-calculation flyTo to render tiles for elevation queries.
…e with lower ones, updated smoothing coefficient and target pitch, updated how unidentified features display on the navigation box UI
…l for river name suggestions)
…ot yet final, it's not hooked up to a db yet and there's no mobile solution yet).
… is being thrown off somewhere in the underlying merit data. This is a problem for some other paths that run through very large inland features, too, but this seems like it will be the most frequent/noticeable manifestation of it, so until it is resolved, I will leave this method in place
…lding layer, though I don't think it'll really make any sense at current zoom levels
…han path-not-found cases
This pull request is being automatically deployed with Vercel (learn more). river-runner-global – ./🔍 Inspect: https://vercel.com/samlearner/river-runner-global/Fu2nuRcJEpK6p3saCrN6WsJ8zGf2 river-runner – ./🔍 Inspect: https://vercel.com/samlearner/river-runner/S4YPQ1YLD9i4GZmag31XVpBhDSi5 |
Changes
This incorporates the new MERIT River Runner API for generating global flowpaths (more information here).
Additionally, addresses a whole host of issues associated with expanding globally, given that there were a lot of assumptions made in building the US-only version that do not hold here. A partial list is documented here:
Some features of notes besides geographic expansion:
Issues of Concern
Note: due to some lingering issues, this version is considered in beta and will not yet be merged into main. It will also exist on a separate URL, here: https://river-runner-global.samlearner.com/, while the original US-only version persists on the original URL, here: https://river-runner.samlearner.com/. Some of these issues will be addressed in the front-end in this repo, others are issues being addressed in the underlying data/API. A few of these issues are notably worse in the global app than in the US-only app, for US flowpaths, which is part of the rationale of maintaining both, for the time being.
A partial list of issues being addressed: