Make make_scalar_function() result candidate for inlining #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
deleted the
findepi/make-make-scalar-function-result-candidate-for-inlining-5763b4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_scalar_functionserves as a template to implement functions, abstracting away processing of scalar values. Whilemake_scalar_functionis a template function, it's not eligible for effective inlining because of theArc<Fn>return type.This commit removes
Arcand unlocks inlining. The change impact was verified manually using on a similarmake_scalar_functionhelper in DataFusion.The change saves some small overhead on each invocation of a UDF, but doesn't improve per-row performance.