Implement Stochastic RSI Indicator #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 98.36% 98.40% +0.03%
==========================================
Files 42 43 +1
Lines 611 626 +15
==========================================
+ Hits 601 616 +15
Misses 7 7
Partials 3 3
Continue to review full report at Codecov.
|
tsubus
force-pushed
the
stochastic_rsi
branch
2 times, most recently
from
a6c5054
to
e4d4a5d
Compare
sdcoffey
reviewed
Mar 17, 2021
indicator_stochastic_rsi.go
Outdated
| } | ||
|
|
||
| type rsiDIndicator struct { | ||
| k Indicator |
There was a problem hiding this comment.
Can we give this a more descriptive name than k?
indicator_stochastic_rsi.go
Outdated
| maxRSI := sri.maxRSI.Calculate(index) | ||
|
|
||
| if minRSI.EQ(maxRSI) { | ||
| return big.NewDecimal(math.Inf(1)) |
There was a problem hiding this comment.
Why Inf here? Wouldn't 0 be a better dummy value?
There was a problem hiding this comment.
The reason it's Inf is simply because dividing by 0 tends to infinity. I'll set it to the maximum value (100).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.investopedia.com/terms/s/stochrsi.asp