Allow import cycles to avoid xtest import problems

Because xtests (package *_test) can import the package they cohabit a
directory with, but ExternalReach() merges normal and test imports
together (and ListPackages() merges test and xtest imports into test
imports), it's possible for it to appear like there's an import cycle,
even though there isn't one in code that would actually compile
together.

The proper solution to this requires refactoring to allow multiple
packages to exist per directory. That's a major undertaking, and really
should only be attempted as part of #99. So, this is a quick fix in the
meantime.

analysis.go

@@ -690,14 +690,17 @@ func wmToReach(workmap map[string]wm, basedir string) map[string][]string {
 			return true
 
 		case grey:
+			// Import cycles can arise in healthy situations through xtests, so
+			// allow them for now.
+			//
+			// FIXME(sdboyer) we need an improved model that allows us to
+			// accurately reject real import cycles.
+			return true
 			// grey means an import cycle; guaranteed badness right here. You'd
 			// hope we never encounter it in a dependency (really? you published
 			// that code?), but we have to defend against it.
-			//
-			// FIXME handle import cycles by dropping everything involved. (i
-			// think we need to compute SCC, then drop *all* of them?)
-			colors[pkg] = black
-			poison(append(path, pkg)) // poison self and parents
+			//colors[pkg] = black
+			//poison(append(path, pkg)) // poison self and parents
 
 		case black:
 			// black means we're done with the package. If it has an entry in
@@ -724,9 +727,6 @@ func wmToReach(workmap map[string]wm, basedir string) map[string][]string {
 		default:
 			panic(fmt.Sprintf("invalid color marker %v for %s", colors[pkg], pkg))
 		}
-
-		// shouldn't ever hit this
-		return false
 	}
 
 	// Run the depth-first exploration.