Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported C++ standards to C++23 and C++20 (dropping C++17) #2091

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

tchaikov
Copy link
Contributor

C++23 has passed all the ballots [1]. We can therefore support it now formally. This means that C++17 is no longer supported, and C++20 is supported until C++26 is released.

The primary benefit of C++23 support is that we can now use coroutines in core Seastar code, as all supported C++ versions have them.

[1] https://lists.isocpp.org/std-proposals/2024/01/8880.php

C++23 has passed all the ballots [1]. We can therefore support it now
formally. This means that C++17 is no longer supported, and C++20 is
supported until C++26 is released.

The primary benefit of C++23 support is that we can now use coroutines
in core Seastar code, as all supported C++ versions have them.

[1] https://lists.isocpp.org/std-proposals/2024/01/8880.php
@tchaikov
Copy link
Contributor Author

this change is based on #2053. on top of which, it also replaces clang++-17 with clang++-18 in .circleci/config.yml.

@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 11, 2024

@avikivity Hi Avi, i took the liberty to rebase your change on the master, and sent this change. this should enable us to start coroutinizing Seastar.

@avikivity avikivity merged commit 5d3ee98 into scylladb:master Feb 11, 2024
14 checks passed
@tchaikov tchaikov deleted the c++23 branch February 12, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants