docker: install clang-tools-18 #2058
Conversation
|
tested using $ podman build -t seastar-dev -f ./docker/dev/Dockerfile .
...
STEP 10/10: CMD /bin/bash
COMMIT seastar-dev
--> c4401e6db9d7
Successfully tagged localhost/seastar-dev:latest
c4401e6db9d7057e6ab910c49a1a2b2bdee5239953c012748cb3406a898739c8 |
|
@avikivity could you help review this change? |
1 similar comment
|
@avikivity could you help review this change? |
|
Why install an unreleased compiler? Is the fix not backported to clang 17? |
no, clang-17 won't get any backport anymore. i prepared the backport on f38, f39 and rawhide, see https://src.fedoraproject.org/rpms/clang/pull-request/226 and https://src.fedoraproject.org/rpms/clang/pull-request/225. but i am too lazy to file a ticket on BTS and/ore on launchpad. |
|
ok. It's not great but not much we can do. |
to address the build failure caused by llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2058 [avi: regenerate toolchain]
to address the build failure caused by llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023. since we now install `clang-tools-18`, circleci is updated to build C++20 module with clang-18. as clang-tools-18 provides clang-scan-deps. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2058 [avi: regenerate toolchain]
to address the build failure caused by llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023. since we now install `clang-tools-18`, circleci is updated to build C++20 module with clang-18. as clang-tools-18 provides clang-scan-deps. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2058 [avi: regenerate toolchain]
tchaikov
force-pushed
the
clang-18
branch
2 times, most recently
from
100ffd9 to
79cda5e
Compare
to address the build failure caused by llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023. since we now install `clang-tools-18`, circleci is updated to build C++20 module with clang-18. as clang-tools-18 provides clang-scan-deps. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2058 [avi: regenerate toolchain]
to address the build failure caused by llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023. since we now install `clang-tools-18`, circleci is updated to build C++20 module with clang-18. as clang-tools-18 provides clang-scan-deps. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2058 [avi: regenerate toolchain]
|
v2:
|
|
@avikivity hi Avi, mind taking another look? |
|
@avikivity ping? |
|
Is this the same build script as was used to generate the image referenced in .circleci? I don't remember the gpg stuff. |
@avikivity it is. please compare it with #2070 . without installing GnuPG, it's impossible to import LLVM's keyring into the system, and we would not be able to install their debian packages without bypassing the signature check. |
to address the build failure caused by llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023. since we now install `clang-tools-18`, circleci is updated to build C++20 module with clang-18. as clang-tools-18 provides clang-scan-deps. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2058 [avi: regenerate toolchain]
to address the build failure caused by
llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023.