build: prevent gcc -Wstringop-overflow workaround from affecting clang #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jan 24, 2024
CMakeLists.txt
Outdated
| @@ -798,7 +798,7 @@ set (Seastar_PRIVATE_CXX_FLAGS | |||
| -Wno-error=deprecated) | |||
|
|
|||
| include (CheckGcc107852) | |||
| if (NOT Cxx_Compiler_BZ107852_Free) | |||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT Cxx_Compiler_BZ107852_Free) | |||
There was a problem hiding this comment.
probably a better fix is to guard the check with CMAKE_CXX_COMPILER_ID STREQUAL "GNU" , like
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
include (CheckGcc107852)
if (NOT Cxx_Compiler_BZ107852_Free)
list (APPEND Seastar_PRIVATE_CXX_FLAGS
-Wno-error=stringop-overflow
-Wno-error=array-bounds)
endif ()
endif ()
We check for a gcc-specific bug, but because we inject warning flags, the test fails on newer versions of clang (since it doesn't like the warning flags). Due to the failure, we then inject the workaround for clang builds, which again fails. Fix that by only applying the workaround for gcc.
avikivity
force-pushed
the
tighten-107852-check
branch
from
b8326d4 to
e01f881
Compare
|
v2: only run the check on gcc in the first place |
|
@scylladb/seastar-maint hello maintainers, could you help merge this change? |
graphcareful
pushed a commit
to graphcareful/seastar
that referenced
this pull request
Mar 20, 2024
We check for a gcc-specific bug, but because we inject warning flags, the test fails on newer versions of clang (since it doesn't like the warning flags). Due to the failure, we then inject the workaround for clang builds, which again fails. Fix that by only applying the workaround for gcc. Closes scylladb#2055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check for a gcc-specific bug, but because we inject warning flags, the test fails on newer versions of clang (since it doesn't like the warning flags). Due to the failure, we then inject the workaround for clang builds, which again fails.
Fix that by only applying the workaround for gcc.