docker: install clang-tools-17 #1999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to build with C++20 modules support, CMake needs to use clang-scan-deps, which is packaged by clang-tools-17, see https://packages.debian.org/sid/amd64/clang-tools-17/filelist and https://packages.ubuntu.com/mantic/amd64/clang-tools-17/filelist, so we have to install it in our CI image. Signed-off-by: Kefu Chai <[email protected]>
|
Probably we can switch to GitHub workflow and use something like https://github.com/aminya/setup-cpp? |
|
if this change is approved. we might want to redo the image along with the change of #1997 |
|
@avikivity hi Avi, could you please help review this change? and redo the docker image? |
graphcareful
pushed a commit
to graphcareful/seastar
that referenced
this pull request
Mar 20, 2024
to build with C++20 modules support, CMake needs to use clang-scan-deps, which is packaged by clang-tools-17, see https://packages.debian.org/sid/amd64/clang-tools-17/filelist and https://packages.ubuntu.com/mantic/amd64/clang-tools-17/filelist, so we have to install it in our CI image. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#1999 [avi: regenerate docker image]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to build with C++20 modules support, CMake needs to use clang-scan-deps, which is packaged by clang-tools-17, see
https://packages.debian.org/sid/amd64/clang-tools-17/filelist and
https://packages.ubuntu.com/mantic/amd64/clang-tools-17/filelist, so we have to install it in our CI image.