Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/lib: do not include unused headers #18515

Closed
wants to merge 1 commit into from
Closed

test/lib: do not include unused headers #18515

wants to merge 1 commit into from

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented May 4, 2024 •
edited
Loading

these unused includes were identified by clangd. see https://clangd.llvm.org/guides/include-cleaner#unused-include-warning for more details on the "Unused include" warning.

  • cleanup, no need to backport

@tchaikov tchaikov added type/code cleanup backport/none Backport is not required labels May 4, 2024
@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

❌ - Build

Build Details:

  • Duration: 31 min
  • Builder: spider2.cloudius-systems.com

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

❌ - Build

Build Details:

  • Duration: 20 min
  • Builder: spider2.cloudius-systems.com

@tchaikov tchaikov requested a review from denesb as a code owner May 4, 2024 16:05
@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

❌ - Build

Build Details:

  • Duration: 14 min
  • Builder: spider2.cloudius-systems.com

@tchaikov tchaikov requested review from nyh and piodul as code owners May 5, 2024 03:08
@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

❌ - Build

Build Details:

  • Duration: 30 min
  • Builder: spider2.cloudius-systems.com

@tchaikov
test/lib: do not include unused headers
3da5fd8 
these unused includes were identified by clangd. see
https://clangd.llvm.org/guides/include-cleaner#unused-include-warning
for more details on the "Unused include" warning.

Signed-off-by: Kefu Chai <[email protected]>
@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/filtering_test
🔹 boost/index_with_paging_test
🔹 boost/mutation_reader_test
🔹 boost/secondary_index_test
🔹 boost/view_build_test
🔹 boost/view_complex_test
🔹 boost/view_schema_ckey_test
🔹 boost/view_schema_pkey_test
🔹 boost/view_schema_test
✅ - Container Test
❌ - Unit Tests

Build Details:

  • Duration: 5 hr 44 min
  • Builder: spider7.cloudius-systems.com

@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/filtering_test
🔹 boost/index_with_paging_test
🔹 boost/mutation_reader_test
🔹 boost/secondary_index_test
🔹 boost/view_build_test
🔹 boost/view_complex_test
🔹 boost/view_schema_ckey_test
🔹 boost/view_schema_pkey_test
🔹 boost/view_schema_test
✅ - Container Test
✅ - Unit Tests

Build Details:

  • Duration: 5 hr 40 min
  • Builder: spider7.cloudius-systems.com

@tchaikov
Copy link
Contributor Author

tchaikov commented May 5, 2024

🔴 CI State: FAILURE

✅ - Build ✅ - Unit Tests Custom The following new/updated tests ran 100 times for each mode: 🔹 boost/filtering_test 🔹 boost/index_with_paging_test 🔹 boost/mutation_reader_test 🔹 boost/secondary_index_test 🔹 boost/view_build_test 🔹 boost/view_complex_test 🔹 boost/view_schema_ckey_test 🔹 boost/view_schema_pkey_test 🔹 boost/view_schema_test ✅ - Container Test ❌ - Unit Tests

Build Details:

  • Duration: 5 hr 44 min
  • Builder: spider7.cloudius-systems.com

#17369 (i should revisit this issue)

@tchaikov tchaikov deleted the test-lib-iwyu branch May 6, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denesb denesb Awaiting requested review from denesb denesb is a code owner

@nyh nyh Awaiting requested review from nyh nyh is a code owner

@piodul piodul Awaiting requested review from piodul piodul is a code owner

Assignees
No one assigned
Labels
backport/none Backport is not required promoted-to-master type/code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchaikov @scylladb-promoter