-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update time docs to reflect new chrono feature flag name #1123
Conversation
Changes `chrono` -> `chrono-04` to reflect the new name for the feature flag.
|
I believe we need to check other features in this aspect, because there are more that has been recently suffixed with a major version number and the docs might have fallen behind. |
True. I've found suspects in following files:
We should rename I see that |
Also fix some previously unchanged occurences of the `chrono` feature flag.
Just made the requested name changes. I searched for occurrences of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've started the CI and will merge after it passes.
Changes
chrono
->chrono-04
to reflect the new name for the feature flag. This was confusing when I was trying to find the feature flag.Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.