semver_checks: Revert previous workaround #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Are you going to open a PR to this branch in order to check that the Semver Checks are indeed working after the changes? |
|
Yes: Lorak-mmk#2 |
wprzytula
approved these changes
Aug 1, 2024
The change in semver-checks was intentional and `cargo install cargo-semver-checks --no-default-features` is no longer expected to work. The replacement command is `cargo install cargo-semver-checks --no-default-features --features gix-reqwest`. See the release notes for v0.33.0: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.33.0
Lorak-mmk
force-pushed
the
semver-checks-revert
branch
from
8400c32
to
e79becf
Compare
|
Done @wprzytula |
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Aug 22, 2024
semver_checks: Revert previous workaround (cherry picked from commit a707bfd)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in semver-checks turned out to be intentional and
cargo install cargo-semver-checks --no-default-featuresis no longer expected to work.The replacement command is
cargo install cargo-semver-checks --no-default-features --features gix-reqwest.See the release notes for v0.33.0: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.33.0
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.