Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --format=docker to support SHELL instruction in the Dockerfile #616

Merged
merged 1 commit into from
May 27, 2021
Merged

Use --format=docker to support SHELL instruction in the Dockerfile #616

merged 1 commit into from
May 27, 2021

Conversation

tnozicka
Copy link
Contributor

Description of your changes:
SHELL instruction is not in the OCI spec, and podman would ignore it so we use --format=docker.

WARN[0066] SHELL is not supported for OCI image format, [/bin/bash -euEo pipefail -c] will be ignored. Must use `docker` format

We can't use the default because Ubuntu has dash that doesn't support -o pipefail.

@tnozicka tnozicka added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 27, 2021
@tnozicka tnozicka added this to the v1.3 milestone May 27, 2021
@tnozicka tnozicka requested a review from zimnx May 27, 2021 14:39
@tnozicka tnozicka changed the title Use --format=docker to support SHELL instruction Use --format=docker to support SHELL instruction in the Dockerfile May 27, 2021
zimnx
zimnx previously approved these changes May 27, 2021
View reviewed changes
@tnozicka tnozicka requested a review from zimnx May 27, 2021 16:24
@zimnx zimnx enabled auto-merge May 27, 2021 16:25
@zimnx zimnx merged commit 5c7ee44 into scylladb:master May 27, 2021
@tnozicka tnozicka deleted the docker-format branch May 28, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnozicka @zimnx