Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use REST API for schema agreement check #603

Merged
merged 2 commits into from
May 21, 2021
Merged

Use REST API for schema agreement check #603

merged 2 commits into from
May 21, 2021

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented May 20, 2021

CQL may require authentication, and there's no way to provide
credentials to Operator. For schema agreement we can consult REST API
where authentication will be managed by the Operator.

@zimnx zimnx added the kind/bug Categorizes issue or PR as related to a bug. label May 20, 2021
@zimnx zimnx added this to the v1.3 milestone May 20, 2021
@zimnx zimnx requested a review from tnozicka May 20, 2021 14:57
@tnozicka tnozicka added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 20, 2021
@tnozicka
Copy link
Contributor

you need go mod tidy && go mod vendor https://github.com/scylladb/scylla-operator/pull/603/checks?check_run_id=2631264947#step:4:168

zimnx added 2 commits May 20, 2021 20:46
@zimnx
Use REST API for schema agreement check
0e03800 
CQL may require authentication, and there's no way to provide
credentials to Operator. For schema agreement we can consult REST API
where authentication will be managed by the Operator.
@zimnx
go mod tidy; go mod vendor
0362609
@zimnx zimnx force-pushed the mz/rest-schema-agreement branch from 072941c to 0362609 Compare May 20, 2021 18:47
@zimnx zimnx requested a review from tnozicka May 20, 2021 18:48
tnozicka
tnozicka approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@zimnx zimnx merged commit 48a22e7 into scylladb:master May 21, 2021
@zimnx zimnx deleted the mz/rest-schema-agreement branch May 21, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimnx @tnozicka