Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document branching and release procedure #559

Merged
merged 1 commit into from
May 4, 2021
Merged

Document branching and release procedure #559

merged 1 commit into from
May 4, 2021

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Apr 26, 2021

No description provided.

@zimnx zimnx force-pushed the mz/release-procedure branch 2 times, most recently from e1176e9 to 992d910 Compare April 26, 2021 10:59
@zimnx zimnx requested a review from tnozicka April 26, 2021 13:36
@zimnx zimnx added this to the v1.3 milestone Apr 26, 2021
@zimnx zimnx added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. kind/documentation Categorizes issue or PR as related to documentation. and removed kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Apr 26, 2021
@zimnx zimnx force-pushed the mz/release-procedure branch from 992d910 to 5bd9431 Compare April 26, 2021 14:25
@zimnx zimnx enabled auto-merge April 26, 2021 14:26
@zimnx zimnx force-pushed the mz/release-procedure branch from 5bd9431 to 82d8e30 Compare April 26, 2021 14:41
tnozicka
tnozicka reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure-wise, would it be better to have just one numbered list with steps?

@zimnx zimnx force-pushed the mz/release-procedure branch from 82d8e30 to d82954a Compare April 27, 2021 17:16
@zimnx zimnx requested a review from tnozicka April 27, 2021 17:16
@zimnx zimnx changed the title release: description of release procedure Written down the release procedure Apr 27, 2021
tnozicka
tnozicka reviewed Apr 28, 2021
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally the tag flow would be:

  1. alpha.0 on the first commit in master
  2. beta.0 on the first commits in release branch (sometime also called a feature candidate)
  3. rc.0 when we close the milestone (all open issues are closed+backported)

@zimnx zimnx force-pushed the mz/release-procedure branch 2 times, most recently from 7895b09 to 76d464b Compare April 29, 2021 11:45
@zimnx zimnx requested a review from tnozicka April 29, 2021 11:45
tnozicka
tnozicka reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally referring to X.X would avoid rewrite with 2.x

@zimnx zimnx force-pushed the mz/release-procedure branch 2 times, most recently from a49a196 to 747890a Compare April 29, 2021 19:22
@tnozicka tnozicka changed the title Written down the release procedure Document branching and release procedure Apr 30, 2021
@zimnx zimnx force-pushed the mz/release-procedure branch from 747890a to 484c082 Compare April 30, 2021 07:46
tnozicka
tnozicka reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to add some changes in 92db604
See if that's something you'd agree with as well.

@zimnx zimnx force-pushed the mz/release-procedure branch 3 times, most recently from c24aa7e to 951a986 Compare April 30, 2021 17:47
tnozicka
tnozicka reviewed May 3, 2021
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, one last nit

@zimnx zimnx force-pushed the mz/release-procedure branch from 951a986 to 51126d5 Compare May 4, 2021 08:01
@zimnx zimnx requested a review from tnozicka May 4, 2021 08:01
tnozicka
tnozicka previously approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@zimnx zimnx force-pushed the mz/release-procedure branch from 51126d5 to a9c3987 Compare May 4, 2021 10:54
@zimnx zimnx merged commit 4f86369 into scylladb:master May 4, 2021
@zimnx zimnx mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimnx @tnozicka