Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: use the same image tag for manifests and images #551

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Apr 16, 2021

No description provided.

@zimnx zimnx requested a review from tnozicka April 16, 2021 17:23
@zimnx zimnx force-pushed the mz/manifests-image-rag branch 3 times, most recently from 19868c1 to 927bee4 Compare April 16, 2021 18:33
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please split generated changes

@zimnx zimnx force-pushed the mz/manifests-image-rag branch 6 times, most recently from 1302e81 to 632663a Compare April 20, 2021 15:29
@zimnx zimnx force-pushed the mz/manifests-image-rag branch from 632663a to 80d6c65 Compare April 26, 2021 13:55
@zimnx zimnx added this to the v1.3 milestone Apr 26, 2021
@zimnx zimnx added the kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. label Apr 26, 2021
tnozicka
tnozicka previously approved these changes Apr 26, 2021
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks

@zimnx zimnx merged commit f85e752 into scylladb:master Apr 26, 2021
@zimnx zimnx deleted the mz/manifests-image-rag branch April 26, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants