Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: add support for arch linux on install dependencies #547

Merged
merged 1 commit into from
Apr 28, 2021
Merged

scripts: add support for arch linux on install dependencies #547

merged 1 commit into from
Apr 28, 2021

Conversation

ashangit
Copy link
Contributor

Description of your changes:

  • add support for arch linux on install dependencies
  • also ensure that tmp build folder is well deleted even if script failed

Which issue is resolved by this Pull Request:
Resolves #

zimnx
zimnx reviewed Apr 20, 2021
View reviewed changes
@ashangit ashangit force-pushed the dependency_deployment branch 2 times, most recently from 3147c80 to ea81d36 Compare April 23, 2021 09:42
@ashangit ashangit requested a review from zimnx April 23, 2021 09:43
@zimnx
Copy link
Collaborator

zimnx commented Apr 27, 2021

Please squash commits, rebase on top of recent master and if you could, provide maintainers access to your PR branch using this tutorial.

@zimnx zimnx added this to the v1.3 milestone Apr 27, 2021
@zimnx zimnx added the kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. label Apr 27, 2021
@ashangit ashangit force-pushed the dependency_deployment branch from ea81d36 to 13934b2 Compare April 27, 2021 19:26
@ashangit
Copy link
Contributor Author

Commits have been squashed
The Allow edits and access to secrets by maintainers is already checked so you should be able update the PR
For my knowledge (to improve other PR) which kind of pattern are you using for this repository (https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-merges)?

@ashangit ashangit force-pushed the dependency_deployment branch from 13934b2 to 0faf3b0 Compare April 28, 2021 09:11
@zimnx zimnx merged commit 631bade into scylladb:master Apr 28, 2021
@ashangit ashangit deleted the dependency_deployment branch April 28, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

Assignees
No one assigned
Labels
kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashangit @zimnx