Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend NodeConfig with loop device management #1691

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Extend NodeConfig with loop device management #1691

merged 2 commits into from
Feb 21, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Jan 17, 2024 •
edited
Loading

v1alpha1.NodeConfig was extended with loop device management.
Users not having a dedicated block device can create a loop device and
use other available options to set up the storage for ScyllaCluster.

@zimnx zimnx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 17, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@zimnx: GitHub didn't allow me to request PR reviews from the following users: zimnx.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

v1alpha1.NodeConfig was extended with loop device management.
Users not having a dedicated block device can create a loop device and
use other available options to set up the storage for ScyllaCluster.

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2024
@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from 4a71917 to 4716ad2 Compare January 17, 2024 20:19
@zimnx zimnx changed the title [WIP] Extend NodeConfig with loop device management Extend NodeConfig with loop device management Jan 17, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2024
@zimnx zimnx requested review from tnozicka and rzetelskik January 17, 2024 20:20
@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from 4716ad2 to a21ec5c Compare January 18, 2024 10:20
@zimnx
Copy link
Collaborator Author

zimnx commented Jan 18, 2024

Manager flake - #1694
/retest

@zimnx
Copy link
Collaborator Author

zimnx commented Jan 18, 2024

Flake - #1695
/retest

@zimnx
Copy link
Collaborator Author

zimnx commented Jan 18, 2024

Flake - #1696
/retest

tnozicka
tnozicka reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part 1

@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from a21ec5c to 9c540a4 Compare January 23, 2024 11:02
@zimnx zimnx requested a review from tnozicka January 23, 2024 11:03
@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch 2 times, most recently from d5b51aa to 549822b Compare January 24, 2024 11:29
@zimnx
Copy link
Collaborator Author

zimnx commented Jan 29, 2024

#1525 (comment)
/retest

@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from 549822b to 802f442 Compare January 29, 2024 13:21
tnozicka
tnozicka reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

a few nits

@tnozicka
Copy link
Contributor

tnozicka commented Feb 1, 2024

I've also run this on my VM with

spec:
  localDiskSetup:
    filesystems:
    - device: /dev/loop/nc-disk-0
      type: xfs
    loopDevices:
    - imagePath: /mnt/nc-disk-0.img
      name: nc-disk-0
      size: 16Gi
    mounts:
    - device: /dev/loops/nc-disk-0
      mountPoint: /mnt/persistent-volumes
      unsupportedOptions:
      - prjquota

and it worked fine

@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch 2 times, most recently from 7f272a9 to c083e91 Compare February 2, 2024 17:30
@zimnx
Copy link
Collaborator Author

zimnx commented Feb 6, 2024

Cluster provisioning failed
/retest

@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from c083e91 to eff0735 Compare February 6, 2024 13:57
@zimnx zimnx requested a review from tnozicka February 6, 2024 13:58
@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from eff0735 to 85ba578 Compare February 15, 2024 19:04
tnozicka
tnozicka reviewed Feb 16, 2024
View reviewed changes
@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from 85ba578 to 91344e2 Compare February 16, 2024 11:12
@zimnx zimnx requested a review from tnozicka February 16, 2024 11:12
@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from 91344e2 to 36be442 Compare February 19, 2024 13:23
@zimnx zimnx requested a review from tnozicka February 19, 2024 22:01
zimnx added 2 commits February 21, 2024 15:54
@zimnx
Extend NodeConfig with loop device management
ed7f3f7 
v1alpha1.NodeConfig was extended with loop device management.
Users not having a dedicated block device can create a loop device and
use other available options to set up the storage for ScyllaCluster.
@zimnx
Update autogenerated
2ef605e
@zimnx zimnx force-pushed the mz/loop-devices-in-nodeconfig branch from 36be442 to 2ef605e Compare February 21, 2024 14:54
tnozicka
tnozicka approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

thanks, glad we finally have local storage for everyone!

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit e8dd337 into scylladb:master Feb 21, 2024
12 of 13 checks passed
tnozicka pushed a commit to tnozicka/scylla-operator that referenced this pull request Feb 23, 2024
@scylla-operator-bot @tnozicka
Merge pull request scylladb#1691 from zimnx/mz/loop-devices-in-nodeco…
f2be911 
…nfig

Extend NodeConfig with loop device management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimnx @tnozicka