Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust image references for introspection with containerd #1619

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Dec 6, 2023

Description of your changes:
Based on #1617 (comment) it seems that containerd can't pull the references published by itself through CRI :(

Warning  InspectFailed     109s (x72 over 16m)  kubelet            Failed to apply default image tag "docker-pullable://scylladb/scylla-operator@sha256:418ed93e3c201bf3e9322b66afeb2ca215f0b821c08ee4dd09620703491da5dc": couldn't parse image name "docker-pullable://scylladb/scylla-operator@sha256:418ed93e3c201bf3e9322b66afeb2ca215f0b821c08ee4dd09620703491da5dc": invalid reference format

This PR strips the prefix as a workaround to containerd issue.

Which issue is resolved by this Pull Request:
Resolves #1617

@tnozicka tnozicka added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 6, 2023
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2023
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 6, 2023

#1028 (comment)
/retest

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 68c8c05 into scylladb:master Dec 6, 2023
@tnozicka tnozicka deleted the introspection branch December 6, 2023 14:03
@tnozicka tnozicka mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Scylla fails with Init:InvalidImageName on pod/scylla-manager-manager-dc-manager-rack-0
2 participants