Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved experience when working with Archive #2177

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

amnonh
Copy link
Collaborator

@amnonh amnonh commented Feb 13, 2024

The ---archive command line option is used by advanced users for offline monitoring analysis.

This series makes the experience easier with the following changes:

  1. pass the directory with the archive command line argument
  2. add command line validate (for example, if you forgot to add that data directory)
  3. validate that the directory exists
  4. the monitoring stack will try to find the Scylla version from that directory. If it's there, no need to specify it
  5. when using master, the monitoring stack will generate the dashboards for you.

Breaking changes:

  1. you now need to specify the directory when using the --archive command line flag
  2. when using the master branch, you need to have Python installed.

…ectory

This patch makes it possible to run multiple monitoring stack from the
same monitoring directory by placing the grafana generated files in a
dedicatd directory.
@amnonh amnonh added this to the Monitoring 4.7 milestone Feb 13, 2024
This patch makes the use of archive and the master branch easier.

Both usages are for advanced users that works on historical data.

After this change the archive command line flag will get a directory as
a parameter.

It will look for the scylla-monitoring scylla.txt in that directory, if
found it will use it to start the monitoring stack for the given
version.

Additional changes, parameter validation, if a long command line flag is
passed without a value, it will generate an error.

Running with the master branch will generate the dashboards for you.
Note that it requires python.

Signed-off-by: Amnon Heiman <[email protected]>
@amnonh amnonh changed the title Improve working with Archive experience Improved experience when working with Archive Feb 13, 2024
@amnonh amnonh merged commit fef59ca into scylladb:master Feb 13, 2024
@amnonh amnonh deleted the archive branch February 13, 2024 09:29
@amnonh amnonh added the breaking-changes This change is not backward compatible label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes This change is not backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant